Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change from site.url to site.website #59

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Change from site.url to site.website #59

merged 1 commit into from
Nov 21, 2023

Conversation

samwilson
Copy link
Member

This fixes the generated URLs in the icalendar feed and the og:image metadata.

The former doesn't exist in _config.yml, I guess the usage was from when it did.

@samwilson
Change from site.url to site.website
f4e0cd9 
This fixes the generated URLs in the icalendar feed and
the og:image metadata.

The former doesn't exist in _config.yml, I guess the usage was
from when it did.
@BudgieInWA
Copy link
Contributor

Oh, neat! Interestingly, when I build locally, site.url is correctly set to http://localhost:4000 (as per the command line server/port config), so it looks like the GitHub build setup doesn't populate it as expected. This is a good workaround.

@samwilson samwilson merged commit b899b91 into main Nov 21, 2023
1 check passed
@samwilson samwilson deleted the site-url branch November 21, 2023 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samwilson @BudgieInWA